about dialog: Fix page visibility

The handling of page visibility broke when the dialog
was ported to GtkStackPage in 52b83ac5530940bf17bc.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1877

diff --git a/gtk/gtkaboutdialog.c b/gtk/gtkaboutdialog.c
index 1105a966e983cad91023937aebbafb51df05f928..d82e32a6e589dda332ea7834e4a53f92b590faa0 100644 (file)
--- a/gtk/gtkaboutdialog.c
+++ b/gtk/gtkaboutdialog.c
@@ -684,7 +684,7 @@ update_credits_button_visibility (GtkAboutDialog *about)
   gboolean show;
   GtkStackPage *page;
 
-  page = gtk_stack_get_page (GTK_STACK (priv->stack), priv->system_page);
+  page = gtk_stack_get_page (GTK_STACK (priv->stack), priv->credits_page);
 
   show = (priv->authors != NULL ||
           priv->documenters != NULL ||
@@ -2155,7 +2155,6 @@ add_credits_section (GtkAboutDialog  *about,
   gtk_widget_set_halign (label, GTK_ALIGN_END);
   gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
   gtk_grid_attach (grid, label, 0, *row, 1, 1);
-  gtk_widget_show (label);
 
   for (p = people; *p; p++)
     {

diff --git a/gtk/ui/gtkaboutdialog.ui b/gtk/ui/gtkaboutdialog.ui
index e339138a8ab44158f006c0951d06a202a531597b..c457a4ebd50e03f2ab3f685b1defa009538aa5ff 100644 (file)
--- a/gtk/ui/gtkaboutdialog.ui
+++ b/gtk/ui/gtkaboutdialog.ui
@@ -111,6 +111,7 @@
                 <child>
                   <object class="GtkStackPage">
                     <property name="name">credits</property>
+                    <property name="visible">0</property>
                     <property name="title" translatable="yes">Credits</property>
                     <property name="child">
                       <object class="GtkBox" id="credits_page">
@@ -147,6 +148,7 @@
                 <child>
                   <object class="GtkStackPage">
                     <property name="name">license</property>
+                    <property name="visible">0</property>
                     <property name="title" translatable="yes">License</property>
                     <property name="child">
                       <object class="GtkBox" id="license_page">
@@ -189,6 +191,7 @@
                 <child>
                   <object class="GtkStackPage">
                     <property name="name">system</property>
+                    <property name="visible">0</property>
                     <property name="title" translatable="yes">System</property>
                     <property name="child">
                       <object class="GtkBox" id="system_page">